Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave syncer (uplift to 0.70.x) #3232

Merged
merged 2 commits into from Aug 28, 2019
Merged

Brave syncer (uplift to 0.70.x) #3232

merged 2 commits into from Aug 28, 2019

Conversation

@darkdh
Copy link
Member

darkdh commented Aug 20, 2019 •
edited

Uplift of #2010 which is required by upcoming C77 bump
#3241 is the bookmark out of order fix
@darkdh darkdh added this to the 0.70.x - Dev milestone Aug 20, 2019
@darkdh darkdh requested review from bbondy and brave/uplift-approvers Aug 20, 2019
@darkdh darkdh requested a review from bridiver as a code owner Aug 20, 2019
@darkdh darkdh self-assigned this Aug 20, 2019
darkdh and others added 2 commits Aug 20, 2019
@darkdh
Merge pull request #2010 from brave/brave-syncer
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
56c2a47 
Brave syncer
@bbondy @darkdh
Merge pull request #3241 from brave/sync-nodes-order-consistency
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
Loading status checks…
d24ee89 
Update sync nodes index only when we are about to moving the nodes from end to proper position
@darkdh darkdh force-pushed the brave-syncer-0.70.x branch from 9209cc0 to d24ee89 Aug 23, 2019
@kjozwiak kjozwiak mentioned this pull request Aug 27, 2019
Merged
@kjozwiak
kjozwiak approved these changes Aug 28, 2019
View changes
Copy link
Member

kjozwiak left a comment

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Looks like CI/Travis passed and the only failure under CI/Jenkins was copying the files into S3. @btlechowski has also gone through brave/brave-browser#2754 (comment).

Please make sure that all the correct labels are added and the appropriate issue is moved into the correct milestone.
@bbondy bbondy merged commit 1944a86 into 0.70.x Aug 28, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the brave-syncer-0.70.x branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

@bridiver bridiver

@bbondy bbondy

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
  0.69.x - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@darkdh @kjozwiak @bbondy
You can’t perform that action at this time.