Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd missing dep for brave content_settings #3233
Conversation
|
should we also make CI also running debug build? This fix is mainly for debug build |
|
@darkdh We can manually run debug build with CI build option (https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-3233/build) |
|
yep, I mean we have to trigger debug build after release build is done |
|
release build passed https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-3233/3/ |
|
ci errors are fixed by another PR and not related to this PR |
add missing dep for brave content_settings
add missing dep for brave content_settings
add missing dep for brave content_settings
|
Verified this is in 0.71.x (milestone already set properly) - commit visible here https://github.com/brave/brave-core/commits/0.71.x?after=886f8520767f78e257397cfa47ef585b35bf1aca+174 Will need to uplift to 0.70.x |
add missing dep for brave content_settings
bridiver commentedAug 20, 2019
•
edited
fix brave/brave-browser#5735
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.