Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dep for brave content_settings #3233

Merged
merged 1 commit into from Aug 21, 2019
Merged

add missing dep for brave content_settings #3233

merged 1 commit into from Aug 21, 2019

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Aug 20, 2019

fix brave/brave-browser#5735

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bridiver bridiver self-assigned this Aug 20, 2019
@bridiver bridiver added this to the 0.71.x - Nightly milestone Aug 20, 2019
@bridiver bridiver force-pushed the issues/5735 branch from 4576015 to 661177f Aug 20, 2019
@darkdh
darkdh approved these changes Aug 20, 2019
@darkdh
Copy link
Member

darkdh commented Aug 20, 2019

should we also make CI also running debug build? This fix is mainly for debug build

@simonhong
Copy link
Collaborator

simonhong commented Aug 21, 2019

@darkdh We can manually run debug build with CI build option (https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-3233/build)

@darkdh
Copy link
Member

darkdh commented Aug 21, 2019

yep, I mean we have to trigger debug build after release build is done

@bridiver
Copy link
Collaborator Author

bridiver commented Aug 21, 2019

ci errors are fixed by another PR and not related to this PR

@bridiver bridiver merged commit a4bba44 into master Aug 21, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bridiver bridiver deleted the issues/5735 branch Aug 21, 2019
bridiver added a commit that referenced this pull request Aug 28, 2019
add missing dep for brave content_settings
bridiver added a commit that referenced this pull request Aug 29, 2019
add missing dep for brave content_settings
@bridiver bridiver mentioned this pull request Aug 29, 2019
bridiver added a commit that referenced this pull request Aug 29, 2019
add missing dep for brave content_settings
@bsclifton
Copy link
Member

bsclifton commented Sep 12, 2019

Verified this is in 0.71.x (milestone already set properly) - commit visible here https://github.com/brave/brave-core/commits/0.71.x?after=886f8520767f78e257397cfa47ef585b35bf1aca+174

Will need to uplift to 0.70.x

bsclifton added a commit that referenced this pull request Sep 12, 2019
add missing dep for brave content_settings
@bsclifton bsclifton mentioned this pull request Sep 12, 2019
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.