Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix layering violations in component updater and add missing dep 0.69.x #3288
Conversation
change brave shields method names for clarity fix brave/brave-browser#5470
Issue 2351: Brave NetworkServicification
bridiver
changed the title
use chromium cookie settings
fix layering violations in component updater and add missing dep
|
closing in favor of a single uplift request #3291 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedAug 28, 2019
Uplift of #3211 for network service
Must merge #3287 first