Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dep for brave content_settings 0.69.x #3290

Closed
wants to merge 7 commits into from
Closed

add missing dep for brave content_settings 0.69.x #3290

wants to merge 7 commits into from

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Aug 28, 2019

Uplift of #3233 for network service
Must merge #3289 first
bridiver added 3 commits Jul 26, 2019
@bridiver
consolidate shields logic
Loading status checks…
78e0ae4 
fix brave/brave-browser#5416
@bridiver
add callbacks for extension set* methods
Loading status checks…
8eb29bd 
change brave shields method names for clarity
fix brave/brave-browser#5470
@bridiver
Merge pull request #2988 from brave/shields_network_service_final
Loading status checks…
4a04649 
Issue 2351: Brave NetworkServicification
@bridiver bridiver added this to the 0.69.x - Beta milestone Aug 28, 2019
@bridiver bridiver requested review from bbondy, kjozwiak and bsclifton Aug 28, 2019
@bridiver bridiver self-assigned this Aug 28, 2019
@bridiver bridiver changed the title Issues/5735 0.69.x add missing dep for brave content_settings 0.69.x Aug 28, 2019
@bridiver bridiver mentioned this pull request Aug 28, 2019
Merged
bridiver added 4 commits Aug 16, 2019
@bridiver
Merge pull request #3130 from brave/brave-cookie-settings-ns
Loading status checks…
17dbd27 
use chromium cookie settings
@bridiver
Merge pull request #3211 from brave/extension_whitelist
Loading status checks…
91a2c74 
fix layering violations in component updater and add missing dep
@bridiver
Merge pull request #3218 from brave/chromium-cookie-prefs
Loading status checks…
dfd9581 
cookie pref value is an int, not a bool
@bridiver
Merge pull request #3233 from /issues/5735
Loading status checks…
9221581 
add missing dep for brave content_settings
@bridiver bridiver force-pushed the issues/5735-0.69.x branch from 9850570 to 9221581 Aug 29, 2019
@bridiver
Copy link
Collaborator Author

bridiver commented Aug 29, 2019

closing in favor of a single uplift request #3291
@bridiver bridiver closed this Aug 29, 2019
@bsclifton bsclifton deleted the issues/5735-0.69.x branch Aug 30, 2019
@bsclifton bsclifton removed this from the 0.69.x - Beta milestone Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

@kjozwiak kjozwiak

@bsclifton bsclifton

Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bridiver @bsclifton
You can’t perform that action at this time.