Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes status type #3311

Merged
merged 1 commit into from Aug 31, 2019
Merged

Fixes status type #3311

merged 1 commit into from Aug 31, 2019

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Aug 30, 2019

Resolves brave/brave-browser#5845

Submitter Checklist:

Test Plan:

  • covered by unit tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Aug 30, 2019
@NejcZdovc NejcZdovc requested a review from kylehickinson Aug 30, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 30, 2019
@NejcZdovc NejcZdovc force-pushed the status-type branch from 3ad3bb4 to 1aac6c0 Aug 30, 2019
@NejcZdovc NejcZdovc force-pushed the status-type branch from 1aac6c0 to e19d38d Aug 30, 2019
@kjozwiak kjozwiak self-requested a review Aug 31, 2019
Copy link
Member

kjozwiak left a comment

LGTM 👍

@NejcZdovc NejcZdovc merged commit 1e6f002 into master Aug 31, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NejcZdovc NejcZdovc deleted the status-type branch Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.