Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for ABP filter redirects as mock responses #3419
Conversation
8315b0d
to
1de6056
6dcdec8
to
fa91445
f271ca1
to
fa4057a
|
LGTM, just mentioned a couple of nits. |
|
This results in less code i wrote shipping in brave-core, so thats an automatic good thing for product ;) More seriously, terrific and fantastic :) |
components/brave_shields/browser/adblock_stub_response_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_shields/browser/adblock_stub_response_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_shields/browser/adblock_stub_response_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_shields/browser/ad_block_service_browsertest.cc
Outdated
Show resolved
Hide resolved
components/brave_shields/browser/ad_block_service_browsertest.cc
Outdated
Show resolved
Hide resolved
|
LGTM in general, mostly readability and style-related comments |
|
Not sure whether this is the right PR for this comment, but as far as I can see from https://github.com/brave/brave-core-crx-packager/pull/74/files#diff-90ea3bb8e019a7c1cb21f2332bf78c75R13, we appear to be pulling the scriptlets directly from the uBlock origin repo. In the security review, @diracdeltas and I manually reviewed all existing scriptlets and then asked for a Brave clone of that repo so that we could review any new ones as they get added. |
|
@fmarier that directory It looks like the URL of the uBlock git archive did end up sneaking through into that PR, but it's not used anywhere and I just filed brave/brave-core-crx-packager#75 to remove it. |
|
Thanks for the clarifications @antonok-edm. |
7736440
to
7434b24
bbondy commentedSep 12, 2019
•
edited
Fix: brave/brave-browser#6894
Unlike extensions like uBlock, we don't do this via
data:URLs.This means that the response will appear to a website as a 200 with the proper mime type, but with the content we want from the resources JSON file.
See also:
brave/internal#660
brave/adblock-rust#29
brave/adblock-rust#50
brave/adblock-rust-ffi#8
brave/brave-core-crx-packager#74
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.