Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WebTorrent to 0.107.16 to fix http-node dep #3446

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@yrliou
Copy link
Member

yrliou commented Sep 16, 2019

Fix brave/brave-browser#6040
Fix brave/devops#1783

Upgrade WebTorrent to have http-node dep fix in webtorrent/webtorrent@d6f77c6

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@yrliou yrliou added this to the 0.72.x - Nightly milestone Sep 16, 2019
@yrliou yrliou self-assigned this Sep 16, 2019
@yrliou yrliou mentioned this pull request Sep 16, 2019
3 of 32 tasks complete
@yrliou yrliou requested review from feross, mbacchi, bsclifton and mihaiplesa Sep 16, 2019
@yrliou
Copy link
Member Author

yrliou commented Sep 16, 2019

I've tested WebTorrent with a local build, didn't see any regression occur.
CI is all green.

Copy link
Member

mbacchi left a comment

Looks great! Thanks!

@yrliou yrliou merged commit 2734583 into master Sep 16, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yrliou yrliou deleted the upgrade_webtorrent_to_0.107.16 branch Sep 16, 2019
brave-builds pushed a commit that referenced this pull request Sep 16, 2019
brave-builds pushed a commit that referenced this pull request Sep 16, 2019
yrliou added a commit that referenced this pull request Sep 16, 2019
Upgrade WebTorrent to 0.107.16 to fix http-node dep
Copy link
Collaborator

feross left a comment

LGTM

fmarier pushed a commit that referenced this pull request Oct 29, 2019
Updates for brave_extension in brave-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.