Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cayman Islands and some other protectorates/territories for Brave Ads #3512

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 23, 2019

Fixes brave/brave-browser#6006

Submitter Checklist:

Test Plan:

  • Confirm ads are available in the Cayman Islands
  • Confirm user is notified that ads are available in the Cayman Islands after an upgrade
  • Confirm user ads are automatically enabled after joining Brave Rewards for fresh installs

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

emerick
emerick previously approved these changes Sep 23, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick previously approved these changes Sep 23, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick previously approved these changes Sep 24, 2019
@tmancey tmancey merged commit a5dc3b3 into master Sep 25, 2019
@tmancey tmancey deleted the issues/6006 branch September 25, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Cayman Islands and some other protectorates/territories for Brave Ads
3 participants