Add built-in support for the wayback machine #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
ca-6144
branch
2 times, most recently
from
8584dfa
to
5d4ef78
Compare
simonhong
force-pushed
the
ca-6144
branch
10 times, most recently
from
b761110
to
509d341
Compare
|
|
simonhong
force-pushed
the
ca-6144
branch
2 times, most recently
from
49beeb6
to
a0f9c77
Compare
|
|
simonhong
force-pushed
the
ca-6144
branch
2 times, most recently
from
e88561f
to
b0a24b1
Compare
|
@simonhong Here you go! |
bridiver
approved these changes
Dec 18, 2019
simonhong
added
CI/skip-android
This change adds the minimal files for built-in support address brave/brave-browser#6144
This adds the ability to turn the Wayback Machine off. Setting can be located under "extension" sidebar item. Address brave/brave-browser#6144
* Assert true that extension is bundled * Assert true that extension is enabled in default windows * Assert false that extension is disabled in Tor windows
This creates a new section to host the Wayback Machine toggle option. Option is located under Additional settings panel as per spec. For further info, see https://docs.google.com/document/d/1ioGkGUVmLE0ndfvLRBjDN1d9QtOKeyPOM-33lK0L78k
fix deps dependency.
Using TabHelper is more efficient than using additional extension.
Wayback machine info bar is attached when WaybackMachineTabHelper detects 404(or similar) error.
With this, other modules can get wayback url easily. Maybe 404 error webui can re-use this in the future.
Implement wayback contents view in separate source file. Fix infinite loop when when reload is requested repeatedly. Don't block navigation for adding infobar.
To do that, custom throbber class is introduced instead of using views::Throbber because it doesn't allow circle color for subclass.
and brave_wayback_machine communicates with brave layer with BraveWaybackMachineDelegate.
Infobar view is created via delegate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close brave/brave-browser#6144
This change adds support for the Wayback Machine by archive.org.
Spec can be found at https://docs.google.com/document/d/1ioGkGUVmLE0ndfvLRBjDN1d9QtOKeyPOM-33lK0L78k/edit#heading=h.n61l82sr1zxg. For convenience I'm attaching the original infobar below.
There are two cases for the infobar:
1.1 If accepted and Wayback machine has records, redirect the user, close the infobar
1.2 If accepted and Wayback machine has no records, update the infobar, as below:
More snapshots
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan
npm run test brave_browser_tests -- --filter=BraveWaybackMachineTest.InfobarAddTest4-1. Click the check button and throbber animation is started
4-1.1 Check an archived version is loaded
4-2. Click x button and infobar is just hidden
Reviewer Checklist:
After-merge Checklist:
changes has landed on.