Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weekly stats pings #3648

Merged
merged 1 commit into from Oct 9, 2019
Merged

Fix weekly stats pings #3648

merged 1 commit into from Oct 9, 2019

Conversation

@emerick
Copy link
Contributor

emerick commented Oct 9, 2019

Fix brave/brave-browser#6386

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@emerick emerick self-assigned this Oct 9, 2019
@emerick emerick force-pushed the incorrect-weekly-pings branch from f013143 to 84fea1c Oct 9, 2019
@emerick emerick requested review from bbondy and aekeus Oct 9, 2019
@bbondy
bbondy approved these changes Oct 9, 2019
@emerick emerick merged commit 3565f62 into master Oct 9, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emerick emerick deleted the incorrect-weekly-pings branch Oct 9, 2019
emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings
emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings
emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings

base::Time GetYMDAsDate(base::StringPiece ymd);
base::Time GetYMDAsDate(const base::StringPiece& ymd);

This comment has been minimized.

Copy link
@iefremov

iefremov Oct 10, 2019

Contributor

JFYI StringPiece is always intentionally passed by value

emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings
emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings
emerick added a commit that referenced this pull request Oct 10, 2019
Fix weekly stats pings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.