Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http-node in package-lock.json (uplift to 0.71.x) #3688

Merged
merged 1 commit into from Oct 14, 2019
Merged

Fix http-node in package-lock.json (uplift to 0.71.x) #3688

merged 1 commit into from Oct 14, 2019

Conversation

@brave-builds
Copy link
Collaborator

brave-builds commented Oct 12, 2019 •
edited by bsclifton

Uplift of #3678

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
@brave-browser-releases
Uplift of #3678 (squashed) to dev
Loading status checks…
7b00ffa
@brave-builds brave-builds self-assigned this Oct 12, 2019
@brave-builds brave-builds added this to the 0.71.x - Dev milestone Oct 12, 2019
@mihaiplesa mihaiplesa added the CI/skip label Oct 12, 2019
@mihaiplesa mihaiplesa requested a review from yrliou Oct 12, 2019
@bsclifton
bsclifton approved these changes Oct 14, 2019
View changes
Copy link
Member

bsclifton left a comment

++
@bsclifton bsclifton merged commit 76ebf62 into 0.71.x Oct 14, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the pr3678_fix_http_node_dep_in_package-lock_0.71.x branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton

@bbondy bbondy

@kjozwiak kjozwiak

@yrliou yrliou

@rebron rebron

@srirambv srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip
Projects
None yet
Milestone
  1.0.0 - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@brave-builds @bsclifton @mihaiplesa @brave-browser-releases
You can’t perform that action at this time.