Trigger sync compaction for bookmarks every week

[darkdh]

fix brave/brave-browser#6552

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

#3749 (comment) can be referenced to generate update records easily

Update

1. Make sure launch old Brave on device A and device B for fresh profiles
2. Sync device A and device B
3. Sync 2 bookmarks
4. Keep changing bookmarks name or URL of the 2 bookmarks for multiple times on device A
5. Make sure device B get all the update
6. Quit Brave on device A and launch new Brave with the same profile
7. Open chrome://inspect/#extensions and inspect Brave Sync on device A
8. After seeing compaction deletes ... on console and wait for extra 3 mins
9. Connect device C to the sync chain
10. Open chrome://inspect/#extensions and inspect Brave Sync on device C
11. You should see exactly got 2 decrypted records in BOOKMARKS after 0 on console
12. And 2 bookmarks are up to date with device A and device B

Delete

1. Make sure launch old Brave on device A and device B for fresh profiles
2. Sync device A and device B
3. Sync 1 bookmark
4. Keep changing bookmarks name or URL of the bookmark for multiple times on device A
5. Make sure device B get all the update
6. Delete the bookmark on device A
7. Make sure device B also deletes the bookmark
8. Quit Brave on device A and launch new Brave with the same profile
9. Open chrome://inspect/#extensions and inspect Brave Sync on device A
10. After seeing compaction deletes ... on console and wait for extra 3 mins
11. Connect device C to the sync chain
12. Open chrome://inspect/#extensions and inspect Brave Sync on device C
13. You should see exactly got 1 decrypted records in BOOKMARKS after 0 on console
14. And device C should still have no bookmark

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[AlexeyBarabash]

PR looks good

[AlexeyBarabash]

Verified it works with STR of:

I. Making bookmarks with lots of updates

1. Get clean profiles A and B
2. Establish the sync chain, wait until there will be two devices
3. Open page brave://bookmarks on device A
4. Call page inspector, right click on tree side => Inspect
5. On console tab paste the code

for (var i = 0; i < 10; ++i) {
chrome.bookmarks.create({'parentId':BOOKMARKS_BAR_ID, 'title': `Bookmark_${i}`,
                         'url': `https://A_${i}.com`});
}

6. Wait while bookmarks will appear on device B
7. On device A paste and enter this in brave://bookmarks Inspector console:

function processNode(node) {
    if(node.children) {
        node.children.forEach(function(child) { processNode(child); });
    }
    if(node.title && node.url) { 
	chrome.bookmarks.update(node.id, {'title': node.title+`_A`});
    }
}
chrome.bookmarks.getTree(function(itemTree){
    itemTree.forEach(function(item){
        processNode(item);
    });
});

paste and run it several times
8. Wait for device B will get the changes
9. Close browser device A

II. Initiating compact operation

1. Open folder of profile A, find Preferences file, in my case this is /home/alexey/.config/BraveSoftware/TEST/A/Default/Preferences
2. Open Preferences file with text editor and remove part like "last_compact_time":"13216219229248049", , save and close file
3. Launch device A
4. Ensure you see compaction deletes messages in console or in inspector console

III. Verifying compact was correct

1. Get clean profile C
2. Copy sync code from device A
3. Connect device C to the sync chain
4. Ensure device C has the same bookmarks as device A
5. See in inspector console for Brave Sync extension get-existing-objects gives objects without repeating by objectId

[bridiver]

FOR_TEST?

[darkdh]

it's been this way since we have BraveSyncEventRouter

[darkdh]

it is just a events::HistogramValue and I can't find a suitable value from the existing list. Should we extend the enum? Please note that brave sync will eventually go away and migrated to native implementation

[bridiver]

shouldn't we wait to do this until the compaction is complete?

[darkdh]

You mean, when the objects are really deleted on s3?
The compaction API is designed to have no callback, if we want callback when the object is really deleted, we would need extra listObject query to check. The deletion is not instant, it takes approximately 1 minute

[darkdh]

Also, the compaction could take a significant long time to pull down all the record if the recordset is huge

[darkdh]

addressed in bb0c6c3
which requires deps update when brave/sync#355 is merged

[SergeyZhukovsky]

++