Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Brave ads browser tests for fresh install and migration paths #3770
Conversation
a47fd54
to
98290e6
9c7da11
to
407ca02
c6f9c9b
to
45864db
e282c1b
to
0eaf0fd
|
|
|
Upgrade path is broken from 0.63 to latest build for supported regions when rewards and ads are enabled. After upgrade ads is disabled. Discussed with @jsecretan and an edge case that is lower priority at this time |
|
Rewards related code change looks good. CI is passing on browser tests as well https://staging.ci.brave.com/job/brave-browser-build-pr/job/issues%252F6518/13/flowGraphTable/ |
This was referenced Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tmancey commentedOct 22, 2019
•
edited
Fixes brave/brave-browser#6518
Requires #3825
Requires #3827
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.