Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave ads browser tests for fresh install and migration paths #3770

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Oct 22, 2019

Fixes brave/brave-browser#6518
Requires #3825
Requires #3827

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@tmancey tmancey requested review from NejcZdovc and masparrow Oct 22, 2019
@tmancey tmancey self-assigned this Oct 22, 2019
@tmancey tmancey requested a review from bridiver Oct 22, 2019
@tmancey tmancey changed the title Add Brave ads browser tests for migration paths Add Brave ads browser tests for fresh install and migration paths Oct 22, 2019
@tmancey tmancey force-pushed the issues/6518 branch 8 times, most recently from a47fd54 to 98290e6 Oct 22, 2019
@tmancey tmancey marked this pull request as ready for review Oct 25, 2019
@tmancey tmancey requested a review from bbondy Oct 25, 2019
@tmancey tmancey force-pushed the issues/6518 branch 12 times, most recently from 9c7da11 to 407ca02 Oct 25, 2019
@tmancey tmancey force-pushed the issues/6518 branch 3 times, most recently from c6f9c9b to 45864db Oct 29, 2019
@tmancey tmancey force-pushed the issues/6518 branch 2 times, most recently from e282c1b to 0eaf0fd Oct 29, 2019
@tmancey tmancey added this to the 0.73.x - Nightly milestone Oct 29, 2019
@tmancey tmancey requested a review from masparrow Oct 29, 2019
Copy link
Contributor

masparrow left a comment

👍

@tmancey
Copy link
Collaborator Author

tmancey commented Oct 29, 2019

Upgrade path is broken from 0.63 to latest build for supported regions when rewards and ads are enabled. After upgrade ads is disabled. Discussed with @jsecretan and an edge case that is lower priority at this time

Copy link
Member

NejcZdovc left a comment

Rewards related code change looks good. CI is passing on browser tests as well https://staging.ci.brave.com/job/brave-browser-build-pr/job/issues%252F6518/13/flowGraphTable/

@tmancey tmancey force-pushed the issues/6518 branch from 0eaf0fd to 1ed9f4e Oct 29, 2019
@tmancey tmancey force-pushed the issues/6518 branch from 1ed9f4e to 33a0a34 Oct 29, 2019
@tmancey tmancey merged commit 7330f69 into master Oct 29, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tmancey tmancey deleted the issues/6518 branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.