Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser tests on Windows due to known issues with MOCK_METHOD #3827

Merged
merged 1 commit into from Oct 30, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix browser tests on Windows due to known issues with MOCK_METHOD

  • Loading branch information
tmancey committed Oct 30, 2019
commit a23ca8428cf144893eb25a50458890bb09125204
@@ -19,7 +19,7 @@ class LocaleHelperMock : public LocaleHelper {
LocaleHelperMock();
~LocaleHelperMock() override;

MOCK_METHOD(const std::string, GetLocale, (), (const, override));
MOCK_CONST_METHOD0(GetLocale, const std::string());

private:
DISALLOW_COPY_AND_ASSIGN(LocaleHelperMock);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.