Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes ac being processed when ac is off #3915
Merged
Conversation
| @@ -251,6 +251,11 @@ bool Contribution::ShouldStartAutoContribute() { | |||
| } | |||
|
|
|||
| void Contribution::StartAutoContribute(uint64_t reconcile_stamp) { | |||
| if (!ShouldStartAutoContribute()) { | |||
This comment has been minimized.
This comment has been minimized.
NejcZdovc
Nov 7, 2019
Author
Member
this is the fix as we didn't checked if AC is enabled before we started it
|
LGTM |
| " .getAttribute(\"data-toggled\") === 'false');" | ||
| " }" | ||
| " }" | ||
| "}, 500);});", |
This comment has been minimized.
This comment has been minimized.
jhoneycutt
Nov 7, 2019
Contributor
There's a WaitForSelector function that will handle some of this work for you.
Resolves brave/brave-browser#6716
This was referenced Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NejcZdovc commentedNov 7, 2019
•
edited
Resolves brave/brave-browser#6716
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.