Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplment OnRecordsSent and delete resend_records within it #3921
Conversation
darkdh
changed the title
|
DEPS will be updated when brave/sync#358 is merged |
| @@ -32,6 +32,7 @@ FORWARD_DECLARE_TEST(BraveSyncServiceTest, ClientOnGetInitData); | |||
| FORWARD_DECLARE_TEST(BraveSyncServiceTest, OnGetInitData); | |||
| FORWARD_DECLARE_TEST(BraveSyncServiceTest, OnSaveBookmarksBaseOrder); | |||
| FORWARD_DECLARE_TEST(BraveSyncServiceTest, OnCompactComplete); | |||
| FORWARD_DECLARE_TEST(BraveSyncServiceTest, OnRecordsSent); | |||
This comment has been minimized.
This comment has been minimized.
AlexeyBarabash
Nov 8, 2019
Contributor
BraveSyncServiceTest doesn't contain the test named OnRecordsSent, looks the actial test is done in (BraveSyncServiceTest, ExponentialResend)
So this line is not required.
This comment has been minimized.
This comment has been minimized.
| @@ -139,6 +143,7 @@ class BraveProfileSyncServiceImpl | |||
| FRIEND_TEST_ALL_PREFIXES(::BraveSyncServiceTest, ClientOnGetInitData); | |||
| FRIEND_TEST_ALL_PREFIXES(::BraveSyncServiceTest, OnSaveBookmarksBaseOrder); | |||
| FRIEND_TEST_ALL_PREFIXES(::BraveSyncServiceTest, OnCompactComplete); | |||
| FRIEND_TEST_ALL_PREFIXES(::BraveSyncServiceTest, OnRecordsSent); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM |
darkdh
force-pushed the
on-sync-records-sent
branch
2 times, most recently
from
9679b3b
to
6603cdc
|
all passed except Android |
darkdh
added
CI/skip-ios
CI/skip-linux
CI/skip-macos
CI/skip-windows
and removed
CI/skip-ios
CI/skip-linux
CI/skip-macos
CI/skip-windows
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedNov 8, 2019
•
edited
fix brave/brave-browser#6834
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.