Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ac being processed when ac is off (uplift to 0.71.x) #3929

Merged
merged 1 commit into from Nov 9, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 8, 2019

Uplift of #3915
Fixes brave/brave-browser#6716

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2019

Restarting Linux due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3915_ac-check_0.71.x/1/execution/node/333/log/:

09:28:17  [39370/39380] AR obj/components/autofill/content/renderer/librenderer.a
09:28:49  Cannot contact i-0cfb1da31655a8063: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@775c553e:i-0cfb1da31655a8063": Remote call on i-0cfb1da31655a8063 failed. The channel is closing down or has closed down
09:33:48  Could not connect to i-0cfb1da31655a8063 to send interrupt signal to process

Restarting macOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3915_ac-check_0.71.x/1/execution/node/543/log/:

13:25:05  [30351/38599] CXX obj/content/browser/browser/child_process_launcher_helper_mac.o
13:25:07  Sending interrupt signal to process
13:25:08  [30352/38599] CXX obj/content/browser/browser/audio_stream_monitor.o
13:25:08  [30353/38599] CXX obj/content/browser/browser/media_internals.o
13:25:12  Sending interrupt signal to process
13:25:13  ninja: build stopped: interrupted by user.
13:25:13  script returned exit code 143

Restarting Win x64 due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3915_ac-check_0.71.x/1/execution/node/241/log/:

09:29:19  Cannot contact i-0f4ac290a4aa7ae26: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@9f2fc0c:i-0f4ac290a4aa7ae26": Remote call on i-0f4ac290a4aa7ae26 failed. The channel is closing down or has closed down
09:34:28  Could not connect to i-0f4ac290a4aa7ae26 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 8, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, bsclifton, kjozwiak, rebron and srirambv November 9, 2019 05:40
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 58b4f97 into 0.71.x Nov 9, 2019
@bsclifton bsclifton deleted the pr3915_ac-check_0.71.x branch November 9, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
5 participants