Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes balance not being fetch when connected to uphold #4007

Merged
merged 1 commit into from Nov 18, 2019
Merged

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Nov 18, 2019

Resolves brave/brave-browser#6886

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to rewards settings page
  • connect to uphold with KYC account that has some BAT in it
  • make sure that when you are redirected back to rewards page and connection is finished that you see balance being updated without page refresh

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 18, 2019
@NejcZdovc NejcZdovc requested a review from brave/rewards Nov 18, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 18, 2019
@NejcZdovc NejcZdovc merged commit 007f861 into master Nov 18, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NejcZdovc NejcZdovc deleted the uphold-balance branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.