Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions for Uphold (netverify and veriff.me) #4039

Merged
merged 3 commits into from Nov 22, 2019
Merged

Exceptions for Uphold (netverify and veriff.me) #4039

merged 3 commits into from Nov 22, 2019

Conversation

@jumde
Copy link
Contributor

jumde commented Nov 20, 2019 •
edited

Uplift of #4012
Uplift of #3425
Uplift of #3381

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
jumde added 3 commits Sep 6, 2019
@jumde
Fix 5891: Update fingerprinting exception for sandbox.uphold.com
4504d62
@jumde
Issue 6007: Add temporary fingerprinting exception for 1password.com
642e828
@jumde
Fix 6983: Add fingerprinting exception for veriff.me on uphold
Loading status checks…
b5f4f32
@jumde jumde requested a review from brave/uplift-approvers Nov 20, 2019
@jumde jumde self-assigned this Nov 20, 2019
@kjozwiak
kjozwiak approved these changes Nov 22, 2019
View changes
Copy link
Member

kjozwiak left a comment

Uplift into 1.0.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors. Please make sure that all the correct labels are used and the associated issue(s) are moved into the correct milestone.
@jumde jumde merged commit cd7c59a into 1.0.x Nov 22, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jumde jumde deleted the uphold_exceptions_1.0.x branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jumde @kjozwiak
You can’t perform that action at this time.