Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pending users where link is not working (uplift to 1.2.x) #4112

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@brave-builds
Copy link
Collaborator

brave-builds commented Dec 2, 2019

Uplift of #4085

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
@brave-builds brave-builds requested a review from NejcZdovc as a code owner Dec 2, 2019
@brave-builds brave-builds self-assigned this Dec 2, 2019
@brave-builds brave-builds added this to the 1.2.x - Dev milestone Dec 2, 2019
@NejcZdovc NejcZdovc removed their request for review Dec 2, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2019

Looks like Linux failed due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4085_uphold-pending_1.2.x/1/execution/node/588/log/ as per:

03:30:46  [30791:30791:1202/083045.775788:ERROR:ledger_impl.cc(103)] Failed to initialize wallet
03:31:53  [30744:30744:1202/083145.711755:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
03:32:15  [30744:30744:1202/083212.419361:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
03:32:47  undefined:18043
03:32:47  {"phase":2,"source":{"id":73,"type":8}]}
03:32:47                                        ^
03:32:47  
03:32:47  SyntaxError: Unexpected token ] in JSON at position 79282903
03:32:47      at JSON.parse (<anonymous>)
03:32:47      at start (/home/ubuntu/jenkins/workspace/d-pr_pr4085_uphold-pending_1.2.x/lib/start.js:144:23)
03:32:47      at Command.listener (/home/ubuntu/jenkins/workspace/d-pr_pr4085_uphold-pending_1.2.x/node_modules/commander/index.js:315:8)
03:32:47      at Command.emit (events.js:210:5)
03:32:47      at Command.parseArgs (/home/ubuntu/jenkins/workspace/d-pr_pr4085_uphold-pending_1.2.x/node_modules/commander/index.js:654:12)
03:32:47      at Command.parse (/home/ubuntu/jenkins/workspace/d-pr_pr4085_uphold-pending_1.2.x/node_modules/commander/index.js:474:21)
03:32:47      at Object.<anonymous> (/home/ubuntu/jenkins/workspace/d-pr_pr4085_uphold-pending_1.2.x/scripts/commands.js:158:4)
03:32:47      at Module._compile (internal/modules/cjs/loader.js:956:30)
03:32:47      at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
03:32:47      at Module.load (internal/modules/cjs/loader.js:812:32)
03:32:47  npm ERR! code ELIFECYCLE

As this is a known intermittent issue on Linux, there's no need to rebuild on Linux.

Copy link
Member

kjozwiak left a comment

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. @LaurenWags also ran through #4085 (comment) and verified it's working correctly under Nightly. CI/Travis passed without any issues but CI/Jenkins failed due to #4112 (comment). However, the failure is a known intermittent issue which passed on the other platforms.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 038f0aa into 1.2.x Dec 3, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kjozwiak kjozwiak deleted the pr4085_uphold-pending_1.2.x branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.