Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply device id v2 #4159

Merged
merged 10 commits into from Dec 30, 2019

Save this device object id for future update

  • Loading branch information
darkdh authored and bridiver committed Dec 3, 2019
commit 3382a507ba6176578ba9a8644b92ac76d3b1b58c
@@ -875,6 +875,7 @@ void BraveProfileSyncServiceImpl::SendCreateDevice() {

std::string device_name = brave_sync_prefs_->GetThisDeviceName();
std::string object_id = tools::GenerateObjectId();
brave_sync_prefs_->SetThisDeviceObjectId(object_id);
std::string device_id = brave_sync_prefs_->GetThisDeviceId();
std::string device_id_v2 = brave_sync_prefs_->GetThisDeviceIdV2();
CHECK(!device_id.empty());
@@ -22,6 +22,7 @@ namespace prefs {

const char kSyncDeviceId[] = "brave_sync.device_id";
const char kSyncDeviceIdV2[] = "brave_sync.device_id_v2";
const char kSyncDeviceObjectId[] = "brave_sync.device_object_id";
const char kSyncSeed[] = "brave_sync.seed";
const char kSyncPrevSeed[] = "brave_sync.previous_seed";
const char kSyncDeviceName[] = "brave_sync.device_name";
@@ -48,6 +49,7 @@ Prefs::Prefs(PrefService* pref_service) : pref_service_(pref_service) {}
void Prefs::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterStringPref(prefs::kSyncDeviceId, std::string());
registry->RegisterStringPref(prefs::kSyncDeviceIdV2, std::string());
registry->RegisterStringPref(prefs::kSyncDeviceObjectId, std::string());
registry->RegisterStringPref(prefs::kSyncSeed, std::string());
registry->RegisterStringPref(prefs::kSyncPrevSeed, std::string());
registry->RegisterStringPref(prefs::kSyncDeviceName, std::string());
@@ -99,6 +101,15 @@ void Prefs::SetThisDeviceIdV2(const std::string& device_id_v2) {
pref_service_->SetString(kSyncDeviceIdV2, device_id_v2);
}

std::string Prefs::GetThisDeviceObjectId() const {
return pref_service_->GetString(kSyncDeviceObjectId);
}

void Prefs::SetThisDeviceObjectId(const std::string& device_object_id) {
DCHECK(!device_object_id.empty());
pref_service_->SetString(kSyncDeviceObjectId, device_object_id);
}

std::string Prefs::GetThisDeviceName() const {
return pref_service_->GetString(kSyncDeviceName);
}
@@ -266,6 +277,8 @@ void Prefs::SetRecordToResendMeta(const std::string& object_id,

void Prefs::Clear() {
pref_service_->ClearPref(kSyncDeviceId);
pref_service_->ClearPref(kSyncDeviceIdV2);
pref_service_->ClearPref(kSyncDeviceObjectId);
pref_service_->ClearPref(kSyncSeed);
pref_service_->ClearPref(kSyncDeviceName);
pref_service_->ClearPref(kSyncEnabled);
@@ -85,6 +85,8 @@ class Prefs {
void SetThisDeviceId(const std::string& device_id);
std::string GetThisDeviceIdV2() const;
void SetThisDeviceIdV2(const std::string& device_id_v2);
std::string GetThisDeviceObjectId() const;
void SetThisDeviceObjectId(const std::string& device_object_id);
std::string GetThisDeviceName() const;
void SetThisDeviceName(const std::string& device_name);
std::string GetBookmarksBaseOrder();
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.