Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds message to fee transaction (uplift to 1.3.x) #4212

Merged
merged 1 commit into from Dec 13, 2019
Merged

Adds message to fee transaction (uplift to 1.3.x) #4212

merged 1 commit into from Dec 13, 2019

Conversation

@brave-builds
Copy link
Collaborator

brave-builds commented Dec 11, 2019 •
edited by bsclifton

Uplift of #4201

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
@brave-builds brave-builds requested a review from NejcZdovc as a code owner Dec 11, 2019
@brave-builds brave-builds self-assigned this Dec 11, 2019
@brave-builds brave-builds added this to the 1.3.x - Dev milestone Dec 11, 2019
@NejcZdovc NejcZdovc removed their request for review Dec 11, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Dec 11, 2019

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4201_transfer-note_1.3.x/1/execution/node/735/log/ failing.

Restarting Win x64 due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4201_transfer-note_1.3.x/1/execution/node/472/log/ failing.
@kjozwiak
Copy link
Member

kjozwiak commented Dec 11, 2019

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4201_transfer-note_1.3.x/2/execution/node/313/log/ failing.

Restarting Win x64 due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4201_transfer-note_1.3.x/2/execution/node/443/log/ failing.
@brave-browser-releases @bsclifton
Uplift of #4201 (squashed) to dev
Verified
This commit was signed with a verified signature.
bsclifton Brian Clifton
GPG key ID: 50ED18CA5C4C0F73 Learn about signing commits
Loading status checks…
615134e
@bsclifton bsclifton force-pushed the pr4201_transfer-note_1.3.x branch from 5ca92ce to 615134e Dec 12, 2019
@bsclifton
bsclifton approved these changes Dec 13, 2019
View changes
Copy link
Member

bsclifton left a comment

++
@bsclifton bsclifton merged commit fb763c1 into 1.3.x Dec 13, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the pr4201_transfer-note_1.3.x branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton

@bbondy bbondy

@kjozwiak kjozwiak

@rebron rebron

@srirambv srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip-android CI/skip-ios CI/skip-linux
Projects
None yet
Milestone
  1.3.x - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases
You can’t perform that action at this time.