Pass last_fetch_time to fetch-sync-records

[AlexeyBarabash]

Fixes brave/brave-browser#7327

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows

1 test timed out:
    BraveRewardsBrowserTest.ProcessPendingContributions (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2763)

• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

See STR of Option I. and option II. at brave/brave-browser#7327

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[darkdh]

please rebase and squash commits Point to sync-staging server and Updated DEPS of brave sync lib (points to staging)

[AlexeyBarabash]

got CI [ 1.5.21 != 1.5.18 ] 17:14:56 + echo Version mismatch between brave-browser and brave-core in package.json, please try rebasing this branch in brave-core as well 17:14:56 Version mismatch between brave-browser and brave-core in package.json, please try rebasing this branch in brave-core as well

Rebased.

[AlexeyBarabash]

Restarted CI due to
Error: Command 'vpython src/brave/script/download_rust_deps.py' returned non-zero exit status 1 in /Users/jenkins/jenkins/workspace/ser-build-pr_poll_sqs_issue_7327

[AlexeyBarabash]

CI failed due to

17:06:01  [408/427] STAMP obj/chrome/installer/mini_installer/setup_runtime_deps.stamp
17:06:40  Cannot contact i-0132f19b7b8f8e9bb: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@3c317da6:i-0132f19b7b8f8e9bb": Remote call on i-0132f19b7b8f8e9bb failed. The channel is closing down or has closed down
17:11:40  Could not connect to i-0132f19b7b8f8e9bb to send interrupt signal to process

restarted

[AlexeyBarabash]

Tested PR with STR 2, wait 24hrs to force fetch over S3.
Saw a situation when fetch-sync-records failed, so get-existing-object wasn't called, but SetLastPreferencesFetchTime set the fetch time.
This broke the logic, as 1st fetch after 24hrs intended to be from S3 has been skipped, and the next fetch goes through SQS, so records can be missed.

PR needs to be updated. Going to expand get-existing-object callback to return the time fetch-sync-records of corresponding operation. And do update of the last_fetch_time when the operation actually succeeded.

Details log

[25015:25015:0114/143959.049684:ERROR:brave_profile_sync_service_impl.cc(1003)] [BraveSync] FetchDevices last_fetch_time=2020-01-12 12:56:23.536 UTC
[25015:25015:0114/143959.049795:ERROR:brave_profile_sync_service_impl.cc(1005)] [BraveSync] FetchDevices did SetLastPreferencesFetchTime =2020-01-14 12:39:59.049 UTC
[25015:25015:0114/143959.049812:ERROR:brave_profile_sync_service_impl.cc(1011)] [BraveSync] FetchDevices before call SendFetchSyncRecords({kPreferences})
[25015:25015:0114/143959.049827:ERROR:brave_profile_sync_service_impl.cc(1015)] [BraveSync] FetchDevices after call SendFetchSyncRecords({kPreferences})
[25015:25053:0114/143959.126934:ERROR:rewards_service_impl.cc(206)] Failed to read file: /home/alexey/.config/BraveSoftware/TEST/A/Default/ledger_state
[25052:25052:0114/143959.127592:ERROR:ledger_impl.cc(102)] Failed to initialize wallet
[25042:25042:0114/143959.186438:ERROR:sandbox_linux.cc(372)] InitializeSandbox() called with multiple threads in process gpu-process.
[25015:25015:0114/143959.265520:ERROR:brave_profile_sync_service_impl.cc(1003)] [BraveSync] FetchDevices last_fetch_time=2020-01-14 12:39:59.049 UTC
[25015:25015:0114/143959.265580:ERROR:brave_profile_sync_service_impl.cc(1005)] [BraveSync] FetchDevices did SetLastPreferencesFetchTime =2020-01-14 12:39:59.265 UTC
[25015:25015:0114/143959.265602:ERROR:brave_profile_sync_service_impl.cc(1011)] [BraveSync] FetchDevices before call SendFetchSyncRecords({kPreferences})
[25015:25015:0114/143959.265683:ERROR:brave_profile_sync_service_impl.cc(1015)] [BraveSync] FetchDevices after call SendFetchSyncRecords({kPreferences})
[25015:25015:0114/143959.379232:ERROR:brave_profile_sync_service_impl.cc(1003)] [BraveSync] FetchDevices last_fetch_time=2020-01-14 12:39:59.265 UTC
[25015:25015:0114/143959.379377:ERROR:brave_profile_sync_service_impl.cc(1005)] [BraveSync] FetchDevices did SetLastPreferencesFetchTime =2020-01-14 12:39:59.379 UTC
[25015:25015:0114/143959.379438:ERROR:brave_profile_sync_service_impl.cc(1011)] [BraveSync] FetchDevices before call SendFetchSyncRecords({kPreferences})
[25015:25015:0114/143959.379582:ERROR:brave_profile_sync_service_impl.cc(1015)] [BraveSync] FetchDevices after call SendFetchSyncRecords({kPreferences})
[25015:25015:0114/143959.602635:ERROR:CONSOLE(0)] "Error in event handler: TypeError: callbackList.fetch-sync-records is not a function
    at chrome-extension://nomlkjnggnifocmealianaaiobmebgil/extension/background.js:13:37", source: chrome-extension://nomlkjnggnifocmealianaaiobmebgil/_generated_background_page.html (0)
[25015:25015:0114/143959.603053:ERROR:CONSOLE(0)] "Error in event handler: TypeError: callbackList.fetch-sync-records is not a function
    at chrome-extension://nomlkjnggnifocmealianaaiobmebgil/extension/background.js:13:37", source: chrome-extension://nomlkjnggnifocmealianaaiobmebgil/_generated_background_page.html (0)
[25015:25015:0114/144002.152509:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Cannot access contents of url "chrome://bookmarks/". Extension manifest must request permission to access this host.", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html (0)
[25015:25015:0114/144002.168238:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Cannot access contents of url "chrome://sync/". Extension manifest must request permission to access this host.", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html (0)
[25015:25015:0114/144035.362490:ERROR:http_bridge.cc(106)] Not implemented reached in virtual void syncer::HttpBridgeFactory::OnSignalReceived()
[25015:25040:0114/144035.398052:ERROR:process_posix.cc(333)] Unable to terminate process 25047: No such process (3)

[AlexeyBarabash]

Closing, will not be actual with sync v2