Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generateCosmeticBlockingStylesheet implementation w/ tests #4246

Closed
wants to merge 1 commit into from

Conversation

@antonok-edm
Copy link
Collaborator

antonok-edm commented Dec 17, 2019

Fixes brave/brave-browser#7442.

I also took the chance to rename the cosmeticFilterGenericExceptions event to cosmeticFilteringEnabled, since generic exceptions are no longer sent to the content script as per @bridiver's feedback on #3303.

Submitter Checklist:

Test Plan:

New unit tests are added for generateCosmeticBlockingStylesheet to ensure the generated stylesheets are correctly formatted.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@antonok-edm antonok-edm self-assigned this Dec 17, 2019
@antonok-edm antonok-edm requested a review from pes10k Dec 17, 2019
@antonok-edm antonok-edm force-pushed the generate-stylesheet-fix branch from 29ae8c1 to c249641 Dec 17, 2019
@cezaraugusto
Copy link
Member

cezaraugusto commented Mar 14, 2020

Hi @antonok-edm, sorry for the waiting. Can you rebase, please?

@antonok-edm
Copy link
Collaborator Author

antonok-edm commented May 1, 2020

This implementation was updated in a separate PR, closing.

@antonok-edm antonok-edm closed this May 1, 2020
@antonok-edm antonok-edm deleted the generate-stylesheet-fix branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.