Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert cosmetic-filtering-frontend changes which caused GLIBC problem on Linux #4255
Conversation
This reverts commit fe9f891, reversing changes made to 4e6ba95. Was causing problems specifically on Linux because of the Rust dependency. This should fix brave/brave-browser#7055 This will un-fix brave/brave-browser#5381
|
@bridiver did a full local release build on Linux and verified this |
antonok-edm
added a commit
that referenced
this pull request
Dec 20, 2019
antonok-edm
added a commit
that referenced
this pull request
Dec 20, 2019
antonok-edm
added a commit
that referenced
this pull request
Jan 9, 2020
bsclifton
added a commit
that referenced
this pull request
Jan 9, 2020
petemill
added a commit
that referenced
this pull request
Feb 3, 2020
… block component. Reverts the revert of the oringal implementation: "Merge pull request #4255 from brave/bsc-revert-cosmetic-filtering" This reverts commit fcfe38a, reversing changes made to 950778a. Fixes some conflicts as a result of master getting flag features and uses updated adblock-rust-ffi version which provides a slightly different API than for the original implementation.
petemill
added a commit
that referenced
this pull request
Feb 4, 2020
… block component. Reverts the revert of the oringal implementation: "Merge pull request #4255 from brave/bsc-revert-cosmetic-filtering" This reverts commit fcfe38a, reversing changes made to 950778a. Fixes some conflicts as a result of master getting flag features and uses updated adblock-rust-ffi version which provides a slightly different API than for the original implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedDec 18, 2019
This reverts commit fe9f891, reversing
changes made to 4e6ba95.
Was causing problems specifically on Linux because of the Rust dependency.
This should fix brave/brave-browser#7055
This will un-fix brave/brave-browser#5381
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.