Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7633: Add new bucket to ads/rewards p3a metrics. (uplift to 1.4.x) #4627

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@brave-builds
Copy link
Collaborator

brave-builds commented Feb 13, 2020

Uplift of #4414
Fixes brave/brave-browser#7633

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
@brave-builds brave-builds requested a review from NejcZdovc as a code owner Feb 13, 2020
@brave-builds brave-builds self-assigned this Feb 13, 2020
@brave-builds brave-builds added this to the 1.4.x - Beta milestone Feb 13, 2020
@bsclifton bsclifton requested review from brave/uplift-approvers and removed request for bbondy, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv Feb 13, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 13, 2020

Linux failed due network-audit failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4414_ie_p3a_ads_fix_1.4.x/1/execution/node/357/log/. However, it's a known issue and will be addressed via brave/brave-browser#7207.

macOS failed due to test-install as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4414_ie_p3a_ads_fix_1.4.x/1/execution/node/706/log/. However, it's a known issue and not related this specific PR.

Copy link
Member

kjozwiak left a comment

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. As per #4627 (comment), network-audit on Linux failed due to ENOAUDIT and macOS failed due to test-install which are known issues and not specific to this PR.

Please make sure that the correct labels are being used and the associated issue is moved into the correct milestones.

@kjozwiak kjozwiak merged commit ed83079 into 1.4.x Feb 14, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kjozwiak kjozwiak deleted the pr4414_ie_p3a_ads_fix_1.4.x branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.