Bookmarks model not loaded (uplift to 1.5.x)

[AlexeyBarabash]

Uplift of #4588

Approved, please ensure that before merging:

• You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
• You have tested your change on Nightly.
• The PR milestones match the branch they are landing to.

After you merge:

• The associated issue milestone is set to the smallest version that the changes is landed on.

[AlexeyBarabash]

CI failed for iOS

cc.py\" "
22:14:16  ERROR at //build/timestamp.gni:31:19: Script returned non-zero exit code.
22:14:16  build_timestamp = exec_script(compute_build_timestamp,
22:14:16                    ^----------
22:14:16  Current dir: /Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/out/ios_Release/
22:14:16  Command: python /Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/build/compute_build_timestamp.py official
22:14:16  Returned 1.
22:14:16  stderr:

for Linux, could not pass phase of init

18:17:35    File "/home/ubuntu/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/vendor/depot_tools/subprocess2.py", line 170, in __init__
18:17:35      % (str(e), kwargs.get('cwd'), args[0]))
18:17:35  OSError: Execution failed with error: [Errno 11] Resource temporarily unavailable.
18:17:35  Check that /home/ubuntu/cache/chromium.googlesource.com-chromiumos-platform2-system_api or git exist and have execution permission.

for macOS, build

21:45:08  ERROR at //build/timestamp.gni:31:19: Script returned non-zero exit code.
21:45:08  build_timestamp = exec_script(compute_build_timestamp,
21:45:08                    ^----------
21:45:08  Current dir: /Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/out/Release/
21:45:08  Command: python /Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/build/compute_build_timestamp.py official
21:45:08  Returned 1.
21:45:08  stderr:
21:45:08  
21:45:08  Traceback (most recent call last):
21:45:08    File "/Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/build/compute_build_timestamp.py", line 127, in <module>
21:45:08      sys.exit(main())
21:45:08    File "/Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/build/compute_build_timestamp.py", line 113, in main
21:45:08      last_commit_timestamp = int(open(lastchange_file).read())
21:45:08  IOError: [Errno 2] No such file or directory: '/Users/jenkins/jenkins/workspace/bookmarks_model_not_loaded_1.5.x/src/build/util/LASTCHANGE.committime'
21:45:08  
21:45:08  See //base/BUILD.gn:34:1: whence it was imported.
21:45:08  import("//build/timestamp.gni")
21:45:08  ^-----------------------------
21:45:08  See //BUILD.gn:70:5: which caused the file to be included.
21:45:08      "//base:base_perftests",
21:45:08      ^----------------------
21:45:08  null
21:45:08  null

[kjozwiak]

QA we'll need to run through #4588 (comment) on Nightly before we can approve this into 1.5.x.

@AlexeyBarabash did you check this on Nightly?

[AlexeyBarabash]

@kjozwiak
I checked on Nightly updated build 1.7.4 it is not crashed on those steps.

The test plan requires custom-built installer which has an introduced delay, so it is impossible to test by those steps by QA, so brave/brave-browser#8178 has QA/No label.

I went through steps at #4588 (comment) with own built master (v1.7.5) with a mentioned modification and verified it passes.

[kjozwiak]

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis passed without any failures. As per #4688, this will be difficult for QA to check. However, it does appear like we have tests to cover this scenario.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.