Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Resolve npm vulnerabilities (part 3 of 3) #4977
Conversation
|
While this PR gets rid of dependency errors, the storybook commands don't seem to work properly with |
|
Huge props to @ryanml for recommending https://www.npmjs.com/package/npm-force-resolutions |
…t vulnerabilities Helps to fix brave/brave-browser#8722
|
Almost ready for review - need to troubleshoot the travis-ci problem with I believe @cezaraugusto is looking at this |
| @@ -307,6 +308,7 @@ | |||
| "less-loader": "^4.0.5", | |||
| "mkdirp": "^0.5.1", | |||
| "mz": "^2.7.0", | |||
| "npm-force-resolutions": "0.0.3", | |||
This comment has been minimized.
This comment has been minimized.
petemill
Mar 18, 2020
Member
This shouldn't be necessary. The npx command runs a binary in an npm repo (in this case the npm-force-resolutions). It should download the repo and run the necessary command on-demand. Brave itself doesn't need to have the dependency in its source tree as far as I can tell.
This comment has been minimized.
This comment has been minimized.
bsclifton
Mar 18, 2020
Author
Member
right - but preinstall is running npx npm-force-resolutions. If we don't add this, nothing would happen?
|
Closing - this approach caused problems when using with |
bsclifton commentedMar 18, 2020
•
edited
Fixes brave/brave-browser#8722
brave-browser(part 1 of fix)synclibrary (part 2 of fix)Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.