Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rebuild package-lock.json to fix npm audit errors #4998

Closed
wants to merge 1 commit into from

Conversation

@bsclifton
Copy link
Member

bsclifton commented Mar 20, 2020

Fixes brave/brave-browser#8722
Related brave/brave-browser#8788

Updates sync in DEPS to have updated hash from brave/sync#379

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bsclifton bsclifton requested a review from diracdeltas Mar 20, 2020
@bsclifton bsclifton self-assigned this Mar 20, 2020
@bsclifton bsclifton added this to the 1.8.x - Nightly milestone Mar 20, 2020
@bsclifton bsclifton mentioned this pull request Mar 20, 2020
5 of 29 tasks complete
Fixes brave/brave-browser#8722

Updates `sync` in `DEPS` to have updated hash from brave/sync#379
@bsclifton bsclifton force-pushed the bsc-fix-npm branch from 7972ea2 to 9bc347b Mar 20, 2020
@bsclifton bsclifton changed the title Rebuild package-lock.json to fix npm audit errors WIP: Rebuild package-lock.json to fix npm audit errors Mar 23, 2020
@bsclifton
Copy link
Member Author

bsclifton commented Mar 24, 2020

Closing in favor of #5013

@bsclifton bsclifton closed this Mar 24, 2020
@bsclifton bsclifton deleted the bsc-fix-npm branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.