Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify safe browsing label #5335

Merged
merged 1 commit into from Apr 27, 2020
Merged

Modify safe browsing label #5335

merged 1 commit into from Apr 27, 2020

Conversation

@simonhong
Copy link
Collaborator

simonhong commented Apr 23, 2020

Resolves brave/brave-browser#9266
Should be merged with brave/brave-browser#9411 together.

image

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@simonhong simonhong added this to the 1.10.x - Nightly milestone Apr 23, 2020
@simonhong simonhong requested a review from bsclifton Apr 23, 2020
@simonhong simonhong self-assigned this Apr 23, 2020
@simonhong simonhong force-pushed the fix_safe_browing_label branch 2 times, most recently from 919c42e to a61874b Apr 23, 2020
@simonhong simonhong requested a review from rebron Apr 24, 2020
@bsclifton bsclifton force-pushed the fix_safe_browing_label branch from a61874b to 00e9d04 Apr 24, 2020
@bsclifton
Copy link
Member

bsclifton commented Apr 24, 2020

Rebased both this PR and brave/brave-browser#9411 after brave/brave-browser#9431 was merged (CI should pass now! 😄)

@simonhong
Copy link
Collaborator Author

simonhong commented Apr 24, 2020

CI looks good.
It only has INFO: [GoogleTest-1.8] - 1 test report file(s) were found with the pattern 'src/brave_browser_tests.xml' error.

Copy link
Member

bsclifton left a comment

++

@simonhong simonhong merged commit 20348be into master Apr 27, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simonhong simonhong deleted the fix_safe_browing_label branch Apr 27, 2020
simonhong added a commit that referenced this pull request Apr 27, 2020
Modify safe browsing label
simonhong added a commit that referenced this pull request Apr 27, 2020
Modify safe browsing label
@kjozwiak
Copy link
Member

kjozwiak commented Apr 30, 2020

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.10.22 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1909 (Build 18363.815)

Annotation 2020-04-30 114726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.