Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129 #5398

Merged
merged 1 commit into from Apr 28, 2020

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 28, 2020

Fixes brave/brave-browser#9493
Related brave/brave-browser#9494

Submitter Checklist:

Test Plan:

See brave/brave-browser#9493

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone Apr 28, 2020
@bsclifton bsclifton requested a review from mkarolin Apr 28, 2020
@bsclifton bsclifton requested a review from bridiver as a code owner Apr 28, 2020
@bsclifton bsclifton self-assigned this Apr 28, 2020
Copy link
Contributor

mkarolin left a comment

++ pending CI

@bsclifton
Copy link
Member Author

bsclifton commented Apr 28, 2020

CI mostly looks good but has two failures:

@bsclifton
Copy link
Member Author

bsclifton commented Apr 28, 2020

Re-ran - got the same 4 unit tests errors again. That includes these:

23:33:03  C  121.620s Main  [  FAILED  ] ConfirmationsRedeemTokenTest.RedeemToken
23:33:03  C  121.620s Main  [  FAILED  ] ConfirmationsRedeemTokenTest.RetryRedeemToken
@bsclifton
Copy link
Member Author

bsclifton commented Apr 28, 2020

I checked recent PRs merged and @mkarolin ran into this problem too when changing a string. This is not a new error- looks like we have some failing tests now
https://ci.brave.com/job/brave-browser-build-pr/job/maxk-new_tab-l10n/1/execution/node/552/log/

Should be good to go - but checking with @tmancey first

@bsclifton
Copy link
Member Author

bsclifton commented Apr 28, 2020

Shared above with @brave/releng - this may be due to recently updating Android to run tests using emulator. Going to go ahead and merge 👍

@bsclifton bsclifton merged commit 12113f8 into master Apr 28, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bsclifton bsclifton deleted the 81.0.4044.129_master_39 branch Apr 28, 2020
bsclifton added a commit that referenced this pull request Apr 28, 2020
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
bsclifton added a commit that referenced this pull request Apr 28, 2020
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.