Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129 #5398
Conversation
|
++ pending CI |
|
CI mostly looks good but has two failures:
|
|
Re-ran - got the same 4 unit tests errors again. That includes these:
|
|
I checked recent PRs merged and @mkarolin ran into this problem too when changing a string. This is not a new error- looks like we have some failing tests now Should be good to go - but checking with @tmancey first |
|
Shared above with @brave/releng - this may be due to recently updating Android to run tests using emulator. Going to go ahead and merge |
bsclifton
added a commit
that referenced
this pull request
Apr 28, 2020
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
bsclifton
added a commit
that referenced
this pull request
Apr 28, 2020
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedApr 28, 2020
•
edited
Fixes brave/brave-browser#9493
Related brave/brave-browser#9494
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#9493
Reviewer Checklist:
After-merge Checklist:
changes has landed on.