Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129 (uplift to 1.8.x) #5404

Merged
merged 1 commit into from Apr 28, 2020
Merged

Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129 (uplift to 1.8.x) #5404

merged 1 commit into from Apr 28, 2020

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 28, 2020 •
edited by kjozwiak

Uplift of brave/brave-browser#9494
Fixes brave/brave-browser#9493
Related brave/brave-browser#9505

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
@bsclifton
Merge pull request #5398 from brave/81.0.4044.129_master_39
Loading status checks…
f3f7449 
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
@bsclifton bsclifton added this to the 1.8.x - Release milestone Apr 28, 2020
@bsclifton bsclifton requested a review from brave/uplift-approvers Apr 28, 2020
@bsclifton bsclifton requested a review from bridiver as a code owner Apr 28, 2020
@bsclifton bsclifton self-assigned this Apr 28, 2020
@bsclifton bsclifton mentioned this pull request Apr 28, 2020
Merged
4 of 4 tasks complete
@bsclifton bsclifton removed the request for review from bridiver Apr 28, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 28, 2020

Restarting as it looks like the b-b job never started.
@bsclifton
Copy link
Member Author

bsclifton commented Apr 28, 2020

CI looks good on all platforms except iOS; restarting (should be quick)
@kjozwiak
kjozwiak approved these changes Apr 28, 2020
View changes
Copy link
Member

kjozwiak left a comment

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
@kjozwiak kjozwiak merged commit de58a21 into 1.8.x Apr 28, 2020
4 checks passed
4 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kjozwiak kjozwiak deleted the 81.0.4044.129-1.8.x branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

Assignees

@bsclifton bsclifton

Labels
CI/skip-android CI/skip-linux CI/skip-macos CI/skip-windows
Projects
None yet
Milestone
  1.8.x - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bsclifton @kjozwiak
You can’t perform that action at this time.