Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129 (uplift to 1.9.x) #5405

Merged
merged 1 commit into from Apr 28, 2020

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 28, 2020

Uplift of brave/brave-browser#9494
Fixes brave/brave-browser#9493
Related brave/brave-browser#9506

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.
Upgrade patches from Chromium 81.0.4044.122 to Chromium 81.0.4044.129
@bsclifton bsclifton added this to the 1.9.x - Beta milestone Apr 28, 2020
@bsclifton bsclifton requested a review from brave/uplift-approvers Apr 28, 2020
@bsclifton bsclifton requested a review from bridiver as a code owner Apr 28, 2020
@bsclifton bsclifton self-assigned this Apr 28, 2020
@bsclifton bsclifton removed the request for review from bridiver Apr 28, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 28, 2020

Looks like macOS failed due to test-browser failing as per https://ci.brave.com/job/brave-browser-build-pr/job/PR-9506/2/execution/node/615/log/

05:24:22  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6114 ms)
05:24:22  [539/539] BraveRewardsBrowserTest.NotVerifiedWallet (6339 ms)
05:24:22  1 test failed:
05:24:22      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2326)

This a known intermittent issue so not blocking uplift.

Copy link
Member

kjozwiak left a comment

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 4784e95 into 1.9.x Apr 28, 2020
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kjozwiak kjozwiak deleted the 81.0.4044.129-1.9.x branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.