Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Promotion notification is not cleared when error happens. #5520

Merged
merged 1 commit into from May 12, 2020

Conversation

@gdregalo
Copy link
Collaborator

gdregalo commented May 12, 2020

Resolves brave/brave-browser#9657.

Submitter Checklist:

Test Plan:

  1. Open the panel.
  2. Before claiming a promotion, turn off internet.
  3. Press "Claim" button.
  4. Observe a message "Oops,something is wrong. Please try again later."

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@gdregalo
Copy link
Collaborator Author

gdregalo commented May 12, 2020

Screenshot_20200511-192604

Copy link
Collaborator

samartnik left a comment

lgtm

Copy link
Member

SergeyZhukovsky left a comment

++

Copy link
Member

NejcZdovc left a comment

rewards code looks good

@gdregalo gdregalo force-pushed the android-ui-claim-error branch from 9e654f9 to 1ea476d May 12, 2020
@gdregalo gdregalo merged commit c9602d1 into master May 12, 2020
3 checks passed
3 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gdregalo gdregalo deleted the android-ui-claim-error branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.