Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads crash on iOS for ads with an invalid target URL #5614

Merged
merged 1 commit into from May 21, 2020

Conversation

@tmancey
Copy link
Collaborator

tmancey commented May 21, 2020

Resolves brave/brave-browser#9873

Refs brave/brave-ios#2564

Submitter Checklist:

Test Plan:

See brave/brave-browser#9873

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@tmancey tmancey added the feature/ads label May 21, 2020
@tmancey tmancey requested a review from kylehickinson May 21, 2020
@tmancey tmancey self-assigned this May 21, 2020
@tmancey tmancey force-pushed the issues/9873 branch from e9ef2f4 to 31f256a May 21, 2020
@tmancey tmancey merged commit a29b3f3 into master May 21, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@tmancey tmancey deleted the issues/9873 branch May 21, 2020
@tmancey tmancey added this to the 1.11.x - Nightly milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.