Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly claim not redeemed tokens #5619
Merged
Conversation
Resolves brave/brave-browser#9891
| @@ -442,7 +442,8 @@ void DatabaseUnblindedToken::GetRecordsByTriggerIds( | |||
| "SELECT ut.token_id, ut.token_value, ut.public_key, ut.value, " | |||
| "ut.creds_id, ut.expires_at FROM %s as ut " | |||
| "LEFT JOIN creds_batch as cb ON cb.creds_id = ut.creds_id " | |||
| "WHERE cb.trigger_id IN (%s) OR ut.creds_id IS NULL", | |||
| "WHERE ut.redeemed_at = 0 AND " | |||
This comment has been minimized.
This comment has been minimized.
NejcZdovc
May 22, 2020
Author
Member
this is an actual change as we should only return tokens that has redeemed_at equal 0
|
LGTM |
|
CI failed on macos, restating |
LaurenWags
commented
May 27, 2020
•
|
Verified passed with
In my example, I had 80 unblinded tokens in the DB. I marked 4 as redeemed. I should have 76 Encountered and logged brave/brave-browser#9967 while testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


NejcZdovc commentedMay 22, 2020
•
edited
Resolves brave/brave-browser#9891
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
unblinded_tokenstable mark some tokens as redeemed. (you do this with setting timestamp inredeemed_atcolumn)t's)Reviewer Checklist:
After-merge Checklist:
changes has landed on.