Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes sku contribution flow for unblinded tokens #5671
Conversation
| @@ -393,8 +396,13 @@ void Unblinded::OnProcessTokens( | |||
| redeem.token_list = token_list; | |||
| redeem.contribution_id = contribution->contribution_id; | |||
|
|
|||
| credentials_->RedeemTokens(redeem, redeem_callback); | |||
| return; | |||
| if (redeem.processor == ledger::ContributionProcessor::UPHOLD || | |||
This comment has been minimized.
This comment has been minimized.
NejcZdovc
May 27, 2020
Author
Member
for this two processors we need to go through different credentials flow as for brave funds
|
LGTM |
Resolves brave/brave-browser#9962
LaurenWags
commented
May 29, 2020
•
|
@NejcZdovc I'm still seeing the issue @GeetaSarvadnya described in brave/brave-browser#9962. Here are the STR I used: plan 1 from above description: Attempt 1: Attempt 2: In both attempt 1 & 2 I get this: Seems as though AC is not working for me on Nightly with an Uphold wallet.
Update - upon further inspection there seems to be a server side issue with staging env. |
LaurenWags
commented
May 29, 2020
|
Verified passed with
Plan 1:
Plan 2:
|






NejcZdovc commentedMay 27, 2020
•
edited
Resolves brave/brave-browser#9962
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
plan 1:
plan 2:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.