Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upApplied Shields v2 UX to settings and shields panel and use FP V2 by default #5684
Conversation
|
Labels and renaming looks great. Will leave the rest to @pes10k. |
|
Fantastic! |
|
This all looks great to me, terrific @simonhong ! |
|
@bridiver ping to owners review. |
| case ControlType::BLOCK: | ||
| return "block"; | ||
| case ControlType::BLOCK_THIRD_PARTY: | ||
| FALLTHROUGH; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
simonhong
Jun 2, 2020
Author
Collaborator
In the UI, same string default is only used for BLOCK_THIRD_PARTY and DEFAULT.
|
Yep, these are for v2 fingerprinting, but we're aiming to ship v2 in 1.11, so should all line up :) Right now the v2 fingerprinting protects haven't been fully implemented, but have eclipsed what was available in v1, so switching over to v2, even as is, is strictly superior |
| map->SetContentSettingCustomScope( | ||
| ContentSettingsPattern::Wildcard(), ContentSettingsPattern::Wildcard(), | ||
| ContentSettingsType::PLUGINS, brave_shields::kFingerprinting, | ||
| ContentSettingsType::PLUGINS, brave_shields::kFingerprintingV2, | ||
| CONTENT_SETTING_BLOCK); | ||
| map->SetContentSettingCustomScope( |
This comment has been minimized.
This comment has been minimized.
bridiver
Jun 3, 2020
Collaborator
this is not relevant anymore, there is no longer a first/third party scope. Can you please cleanup the tests in a followup?
simonhong commentedMay 28, 2020
•
edited
Resolves brave/brave-browser#9194
Resolves brave/brave-browser#9975
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.