Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Rewards to three decimal places #5699

Merged
merged 1 commit into from Jun 5, 2020
Merged

Expand Rewards to three decimal places #5699

merged 1 commit into from Jun 5, 2020
+72 −72

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Jun 1, 2020

Resolves brave/brave-browser#10027

Submitter Checklist:

Test Plan:

See brave/brave-browser#10027

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@tmancey tmancey added the feature/ads label Jun 1, 2020
@tmancey tmancey self-assigned this Jun 1, 2020
@tmancey tmancey force-pushed the issues/10027 branch from 02722a7 to 062095d Jun 2, 2020
@tmancey tmancey changed the title Expand estimated pending rewards to two decimal places Expand Rewards to two decimal places Jun 2, 2020
@NejcZdovc
NejcZdovc reviewed Jun 2, 2020
View changes
components/brave_rewards/resources/android_page/components/promotion.tsx Outdated Show resolved Hide resolved
@NejcZdovc
NejcZdovc reviewed Jun 2, 2020
View changes
components/brave_rewards/resources/page/components/promotion.tsx Outdated Show resolved Hide resolved
@NejcZdovc
NejcZdovc reviewed Jun 2, 2020
View changes
components/brave_rewards/resources/tip/components/siteBanner.tsx Outdated Show resolved Hide resolved
@NejcZdovc
NejcZdovc reviewed Jun 2, 2020
View changes
components/brave_rewards/resources/ui/components/walletSummary/index.tsx Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the issues/10027 branch from 062095d to e2fd602 Jun 2, 2020
@tmancey tmancey requested a review from NejcZdovc Jun 2, 2020
@moritzhaller
moritzhaller reviewed Jun 2, 2020
View changes
components/brave_rewards/resources/android_page/components/promotion.tsx Outdated Show resolved Hide resolved
@moritzhaller moritzhaller self-requested a review Jun 2, 2020
@tmancey tmancey added the CI/skip label Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch from e2fd602 to ea17f61 Jun 2, 2020
@tmancey tmancey removed the CI/skip label Jun 2, 2020
@tmancey tmancey changed the title Expand Rewards to two decimal places Expand Rewards to 3 decimal places Jun 2, 2020
@tmancey tmancey changed the title Expand Rewards to 3 decimal places Expand Rewards to three decimal places Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch from ea17f61 to 77c88a0 Jun 2, 2020
@tmancey tmancey added the CI/skip label Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from 3a7a3af to 6c8e036 Jun 2, 2020
@tmancey tmancey removed the CI/skip label Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch from 6c8e036 to 4b92c1b Jun 2, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 2, 2020

Failed CI for Linux and macOS, restarting
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from 7b1ee5f to e2849b8 Jun 4, 2020
@NejcZdovc
NejcZdovc requested changes Jun 4, 2020
View changes
Copy link
Member

NejcZdovc left a comment

One was missed https://github.com/brave/brave-core/blob/master/components/brave_rewards/resources/page/components/pageWallet.tsx#L552
@tmancey tmancey requested a review from NejcZdovc Jun 4, 2020
@tmancey tmancey force-pushed the issues/10027 branch from e2849b8 to 5012de7 Jun 4, 2020
@tmancey tmancey requested a review from emerick Jun 4, 2020
@NejcZdovc
Copy link
Member

NejcZdovc commented Jun 4, 2020 •
edited

PR looks good to me. Waiting for confirmation from design team
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from c8c6992 to 8795f4b Jun 4, 2020
@NejcZdovc
NejcZdovc approved these changes Jun 4, 2020
View changes
@NejcZdovc
NejcZdovc requested changes Jun 4, 2020
View changes
Copy link
Member

NejcZdovc left a comment

please fix browser tests
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from ca1b91a to 6c159db Jun 4, 2020
@tmancey tmancey requested a review from NejcZdovc Jun 4, 2020
@tmancey
Expand Rewards to three decimal places
Loading status checks…
30020ff
@tmancey tmancey force-pushed the issues/10027 branch from 6c159db to 30020ff Jun 5, 2020
@NejcZdovc
NejcZdovc approved these changes Jun 5, 2020
View changes
@tmancey tmancey merged commit 8520102 into master Jun 5, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tmancey tmancey deleted the issues/10027 branch Jun 5, 2020
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 5, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 5, 2020

CI failed for known test-install issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc

@moritzhaller moritzhaller

@emerick emerick

@yachtcaptain23 yachtcaptain23

@ryanml ryanml

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
  1.12.x - Nightly
Linked issues

Successfully merging this pull request may close these issues.

Expand Rewards to three decimal places
3 participants
@tmancey @NejcZdovc @moritzhaller
You can’t perform that action at this time.