Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Brave Ads unit tests, mocks, utils and structure #5813

Draft
wants to merge 1 commit into
base: master
from

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Jun 11, 2020

Resolves brave/brave-browser#9471

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@NejcZdovc NejcZdovc requested a review from tmancey as a code owner Jun 11, 2020
@NejcZdovc NejcZdovc added the CI/skip label Jun 11, 2020
@NejcZdovc NejcZdovc marked this pull request as draft Jun 11, 2020
@tmancey tmancey force-pushed the issues/9471 branch 3 times, most recently from e6d7097 to b524c73 Jun 13, 2020
@tmancey tmancey force-pushed the issues/9471 branch from b524c73 to 7fe8beb Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.