Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic logging around AdsServiceImpl URLLoader calls #5836

Open
wants to merge 1 commit into
base: master
from

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Jun 13, 2020

Resolves brave/brave-browser#10248

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@tmancey tmancey added the feature/ads label Jun 13, 2020
@tmancey tmancey requested review from bridiver and fmarier Jun 13, 2020
@tmancey tmancey self-assigned this Jun 13, 2020
@tmancey tmancey marked this pull request as draft Jun 13, 2020
@tmancey tmancey force-pushed the issues/10248 branch from 218557f to 243fc54 Jun 13, 2020
@tmancey tmancey marked this pull request as ready for review Jun 13, 2020
@tmancey tmancey force-pushed the issues/10248 branch from 243fc54 to c37ead4 Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.