Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all use of and references to the referrer exception service #6133

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Jul 21, 2020

Resolves brave/brave-browser#10825

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pes10k pes10k requested a review from iefremov as a code owner July 21, 2020 01:03
@pes10k pes10k added this to the 1.13.x - Nightly milestone Jul 21, 2020
@pes10k pes10k self-assigned this Jul 21, 2020
@pes10k pes10k changed the title remove all use and references to the referrer exception service remove all use of and references to the referrer exception service Jul 21, 2020
@pes10k pes10k force-pushed the remove-referrer-exception-service branch from f6ba312 to 3a6101a Compare July 21, 2020 01:19
@@ -110,9 +110,6 @@ bool ApplyPotentialReferrerBlock(std::shared_ptr<BraveRequestInfo> ctx) {
GURL(ctx->referrer), ctx->tab_origin, ctx->request_url,
content::Referrer::NetReferrerPolicyToBlinkReferrerPolicy(
ctx->referrer_policy),
g_brave_browser_process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we can drop #include "brave/browser/brave_browser_process_impl.h"

@pes10k pes10k force-pushed the remove-referrer-exception-service branch from 3a6101a to 51bbddb Compare July 22, 2020 15:08
@pes10k pes10k force-pushed the remove-referrer-exception-service branch from 51bbddb to 7ba94d7 Compare July 22, 2020 15:09
@pes10k pes10k merged commit e995c99 into master Jul 22, 2020
@pes10k pes10k deleted the remove-referrer-exception-service branch July 22, 2020 18:15
emerick pushed a commit that referenced this pull request Jul 22, 2020
remove all use of and references to the referrer exception service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Remove all referrer exceptions
2 participants