Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet promocode from registry #619
Merged
Conversation
|
LGTM |
| + | ||
| + const wchar_t* last_argument = args[argument_count - 1]; | ||
| + if (StrStartsWith(last_argument, L"--")) | ||
| + if (StrStartsWith(value, L"--")) |
This comment has been minimized.
This comment has been minimized.
emerick
Oct 12, 2018
Contributor
We probably don't need this check, since we're not passing a command-line flag anymore (this check was just to ensure that we were looking at a filename and not a --flag).
The stub installer will parse its own filename and pass it to the mini installer via the command line interface (it should be the last argument on the command line). The mini installer will parse the filename for a referral code and send it to the setup program as usual if found. This will allow referrals to work via the updateable installer.
Stub installer path is fetched from registry instead of args because stub installer will store its path to registry.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
simonhong commentedOct 12, 2018
•
edited
This pr is based on #613.
Promo code will be came from stub installer filename.
To pass promocode stub installer stores its filename that including promocode to registry.
Omaha client PR is here - brave/omaha#5.
Fixes brave/brave-browser#1515
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Create key - \HKEY_CURRENT_USER\BraveSofware\Promo
and add string value (ex, BraveBrowserSetup-RED397.exe) with
StubInstallerPathkey.Then, run mini_installer.
A file named promoCode is written to the user-data-dir
The promoCode file contains the appropriate code (e.g., RED397 in the example given above)
installs as expected
Reviewer Checklist: