Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes night mode option on tablet #6719

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#11783

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 29, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.16.x - Nightly milestone Sep 29, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Sep 29, 2020
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyZhukovsky SergeyZhukovsky merged commit f34ca62 into master Sep 29, 2020
@SergeyZhukovsky SergeyZhukovsky deleted the enable_night_mode_tablet branch September 29, 2020 16:07
brave-builds pushed a commit that referenced this pull request Sep 29, 2020
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.17.1 x64 nightly build

  • Verified enabling night mode prompts browser restart
  • Verified night mode is enabled in flags after restart
  • Verified night mode only works after browser is restarted and clicking on later doesn't change webview to dark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling night mode doesn't trigger browser restart prompt
4 participants