Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrate omaha build into brave-core #722
Merged
Conversation
simonhong
force-pushed the
integrate_omaha_to_brave_core
branch
5 times, most recently
from
f18b1bb
to
9cdf4c1
| @@ -40,10 +42,12 @@ action("create_signed_installer") { | |||
| ] | |||
| outputs = [ | |||
| "$root_out_dir/brave_installer.exe", | |||
| "$root_out_dir/$brave_installer_exe", | |||
This comment has been minimized.
This comment has been minimized.
simonhong
Oct 26, 2018
Author
Collaborator
I didn't delete "$root_out_dir/brave_installer.exe", to preserve existing outputs.
I think this can be removed after CI doesn't use brave_installer.exe anymore.
|
DEPS should be updated after finishing review/merge of brave/omaha#10 |
simonhong
changed the title
When build_omaha is set, create_dist target has omaha dependency and omaha clients(stub/standalone) are built under src/out/Release.
simonhong
force-pushed the
integrate_omaha_to_brave_core
branch
from
6fe51ca
to
cb4c889
|
|
simonhong
force-pushed the
integrate_omaha_to_brave_core
branch
from
cb4c889
to
354f23e
|
LGTM |
emerick
added a commit
that referenced
this pull request
Oct 29, 2018
Integrate omaha build into brave-core
emerick
added a commit
that referenced
this pull request
Oct 29, 2018
Integrate omaha build into brave-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
simonhong commentedOct 24, 2018
•
edited
When build_omaha is set, create_dist target has omaha dependency and
omaha clients(stub/standalone) are built under src/out/Release.
Issue: brave/brave-browser#1784
Close: brave/brave-browser#976
Close: brave/brave-browser#580
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: