Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplits contribution into separate file for better organisation #806
Conversation
f3b9805
to
f1cd434
|
|
Resolves brave/brave-browser#1987
NejcZdovc
added a commit
that referenced
this pull request
Nov 8, 2018
Splits contribution into separate file for better organisation
|
@NejcZdovc approved uplift to |
NejcZdovc
added a commit
that referenced
this pull request
Nov 9, 2018
Splits contribution into separate file for better organisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NejcZdovc commentedNov 5, 2018
•
edited
Resolves brave/brave-browser#1987
Native implementation: brave-intl/bat-native-ledger#168
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: