Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits contribution into separate file for better organisation #806

Merged
merged 1 commit into from Nov 8, 2018

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Nov 5, 2018

Resolves brave/brave-browser#1987

Native implementation: brave-intl/bat-native-ledger#168

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • make sure that contribution is still working

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@NejcZdovc
Copy link
Member Author

NejcZdovc commented Nov 8, 2018

@kjozwiak @rebron @srirambv can we please uplift this to 57? This is part of refactors changes that will be needed to implement retries that are targeted for 57 as well.

@NejcZdovc NejcZdovc force-pushed the refactor-contribution branch from f1cd434 to 763aee3 Nov 8, 2018
@NejcZdovc NejcZdovc requested review from bridiver and tmancey Nov 8, 2018
Copy link
Collaborator

tmancey left a comment

👍

@NejcZdovc NejcZdovc force-pushed the refactor-contribution branch from 763aee3 to 32930d2 Nov 8, 2018
@tmancey
tmancey approved these changes Nov 8, 2018
@NejcZdovc NejcZdovc merged commit c6f623d into master Nov 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NejcZdovc NejcZdovc deleted the refactor-contribution branch Nov 8, 2018
NejcZdovc added a commit that referenced this pull request Nov 8, 2018
Splits contribution into separate file for better organisation
@NejcZdovc
Copy link
Member Author

NejcZdovc commented Nov 8, 2018

master (0.59) c6f623d
0.58.x b503544
0.57.x 3477975

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2018

@NejcZdovc approved uplift to 0.57.x BETA after deliberating with @srirambv & @rebron! 👍

NejcZdovc added a commit that referenced this pull request Nov 9, 2018
Splits contribution into separate file for better organisation
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.