Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpload windows stub/standalone installers to Github. #810
Conversation
Also update DEPS to use the most recent changes that build and sign the installers during the `create_dist --build_omaha` step. Fixes brave/brave-browser#1992
|
How about appending version to uploaded brave_installer.exe and standalone installer? @bbondy |
|
I think it might be easier for some automation and such to not have the version in the filename, but having the version in the file properties should be there. |
|
I checked that brave_installer.exe alreay has proper version info in file properties. |
|
I'll pass to @mihaiplesa for reviewing (I don't know much about uploading stuff) |
|
looks good, can remove some code duplication by having a variable named suffix that takes values of '' or '32' based on arch |
|
Approved uplift to |
Upload windows stub/standalone installers to Github.
Upload windows stub/standalone installers to Github.
Upload windows stub/standalone installers to Github.
mbacchi commentedNov 6, 2018
Also update DEPS to use the most recent changes that
build and sign the installers during the
create_dist --build_omahastep.Fixes brave/brave-browser#1992
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: