Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits native lib state #814

Merged
merged 1 commit into from Nov 6, 2018
Merged

Splits native lib state #814

merged 1 commit into from Nov 6, 2018

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Nov 6, 2018

Resolves brave/brave-browser#1997

Native implementation: brave-intl/bat-native-ledger#171

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@NejcZdovc NejcZdovc self-assigned this Nov 6, 2018
@NejcZdovc NejcZdovc mentioned this pull request Nov 6, 2018
@NejcZdovc NejcZdovc requested a review from bridiver Nov 6, 2018
@NejcZdovc NejcZdovc requested a review from tmancey Nov 6, 2018
@NejcZdovc NejcZdovc force-pushed the split-client-state branch from baf82f6 to 8d4699e Nov 6, 2018
@NejcZdovc NejcZdovc force-pushed the split-client-state branch from 8d4699e to 296394e Nov 6, 2018
@NejcZdovc NejcZdovc merged commit 5c35e03 into master Nov 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NejcZdovc NejcZdovc deleted the split-client-state branch Nov 6, 2018
@NejcZdovc
Copy link
Member Author

NejcZdovc commented Nov 6, 2018

master (0.59) 5c35e03
0.58.x f32ac90
0.57.x 220e380

NejcZdovc added a commit that referenced this pull request Nov 7, 2018
Splits native lib state
@NejcZdovc
Copy link
Member Author

NejcZdovc commented Nov 8, 2018

@kjozwiak @rebron @srirambv can we please uplift this to 57? This is part of refactor series that will be needed to implement retries that are targeted for 57 as well.

@yrliou yrliou mentioned this pull request Nov 8, 2018
4 of 18 tasks complete
@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2018

@NejcZdovc approved uplift to 0.57.x BETA after deliberating with @srirambv & @rebron! 👍

NejcZdovc added a commit that referenced this pull request Nov 9, 2018
Splits native lib state
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.