Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native-ledger DEPS for fixing windows build error #836

Merged
merged 1 commit into from Nov 8, 2018

Conversation

@yrliou
Copy link
Member

yrliou commented Nov 8, 2018

Close brave/brave-browser#2044
native-ledger: brave-intl/bat-native-ledger#173

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@yrliou yrliou self-assigned this Nov 8, 2018
@yrliou yrliou requested a review from NejcZdovc Nov 8, 2018
@NejcZdovc NejcZdovc merged commit c5a4e32 into master Nov 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NejcZdovc NejcZdovc deleted the fix_build_error_windows branch Nov 8, 2018
NejcZdovc added a commit that referenced this pull request Nov 8, 2018
Update native-ledger DEPS for fixing windows build error
@NejcZdovc
Copy link
Member

NejcZdovc commented Nov 8, 2018

master (0.59) c5a4e32
0.58.x 04c8ba6
0.57.x 0ad9c69

@yrliou
Copy link
Member Author

yrliou commented Nov 8, 2018

Note that this PR would need to go in to the same milestone as #814

@NejcZdovc
Copy link
Member

NejcZdovc commented Nov 8, 2018

@kjozwiak @rebron @srirambv can we please uplift this to 57 as well. Needs to go in the same milestone as #814

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2018

@NejcZdovc approved uplift to 0.57.x BETA after deliberating with @srirambv & @rebron! 👍

NejcZdovc added a commit that referenced this pull request Nov 9, 2018
Update native-ledger DEPS for fixing windows build error
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.