Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and upload silent and untagged Windows Omaha installers #974

Merged
merged 3 commits into from Nov 28, 2018
Merged

Conversation

@mbacchi
Copy link
Member

mbacchi commented Nov 28, 2018

Fixes: brave/brave-browser#2210

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@kjozwiak
Copy link
Member

kjozwiak commented Nov 28, 2018

Approving for uplift to 0.57.x after deliberating with @srirambv & @rebron 👍

@mbacchi before tagging issues as uplift-request/0.57.x-Beta, they should usually:

  • have passed review, closed and merged into master
  • merged into dev

Once merged into dev, request for approval 👍

Copy link
Collaborator

mihaiplesa left a comment

looks good

@mihaiplesa mihaiplesa requested review from mihaiplesa and removed request for simonhong Nov 28, 2018
Copy link
Collaborator

mihaiplesa left a comment

let's merge

@mbacchi mbacchi merged commit e3491ee into master Nov 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mbacchi
Copy link
Member Author

mbacchi commented Nov 28, 2018

Thanks @kjozwiak I'll remember that process for the next time. Appreciate your explanation.

@mbacchi mbacchi deleted the issue_2210 branch Nov 28, 2018
mbacchi added a commit that referenced this pull request Nov 28, 2018
Create and upload silent and untagged Windows Omaha installers
mbacchi added a commit that referenced this pull request Nov 28, 2018
Create and upload silent and untagged Windows Omaha installers

Fix merge conflict in package.json:

Conflicts:
	package.json
@mbacchi
Copy link
Member Author

mbacchi commented Nov 28, 2018

master: e3491ee
0.58.x: e9088ff
0.57.x: d59f4e4

@bbondy
Copy link
Member

bbondy commented Nov 28, 2018

adding merged label.

@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
@LaurenWags LaurenWags mentioned this pull request Mar 10, 2020
6 of 32 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.